Skip to content

feat(engine): add isPlanFullyCompleted - #3390

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-is-plan-fully-completed
Jul 5, 2026
Merged

feat(engine): add isPlanFullyCompleted#3390
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-is-plan-fully-completed

Conversation

@kiannidev

@kiannidev kiannidev commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add isPlanFullyCompleted in @jsonbored/gittensory-engine — returns whether every step in a plan DAG is completed (empty plans are not complete).
  • Pure helper alongside plan-export and countPlanStepsByStatus for miner and dashboard completion checks.
  • Vitest coverage at 100% patch on the new helper.

Test plan

  • COVERAGE_NO_THRESHOLDS=1 npx vitest run test/unit/plan-completion.test.ts --coverage
  • npx diff-cover coverage/lcov.info --compare-branch=main --fail-under=99 → 100%
  • npm run build --workspace @jsonbored/gittensory-engine && npm run build:miner

Made with Cursor

@kiannidev @cursoragent
feat(engine): add isPlanFullyCompleted
2bb2fb7 
Expose a pure plan-DAG completion check for miner and dashboard flows that need a single done/not-done signal.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev
kiannidev requested a review from JSONbored as a code owner July 5, 2026 06:00
@superagent-security

superagent-security Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 06:22:42 UTC

3 files · 1 AI reviewer · no blockers · readiness 55/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This adds a narrow pure helper that matches the stated contract: non-empty plans complete only when every step status is `completed`, and it is exported through the engine barrel. The unit tests cover the empty, all-completed, mixed, failed, and barrel-export paths, so the visible diff is safe enough to proceed.

Nits — 3 non-blocking
  • nit: test/unit/plan-completion.test.ts:5 names the override parameter `over`, which reads like a typo; rename it to `overrides` for readability.
  • packages/gittensory-engine/src/plan-completion.ts:7 is intentionally status-only; if DAG validity matters to downstream callers, keep that as a separate helper rather than folding dependency validation into this completion predicate.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 1362 registered-repo PR(s), 668 merged, 49 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 1362 PR(s), 49 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 1362 PR(s), 49 issue(s).
  • Related work: Titles/paths share 10 meaningful terms. (issue #2281, issue #2276)
  • Related work: Titles/paths share 10 meaningful terms. (issue #2038, issue #2040)
  • Related work: Titles/paths share 5 meaningful terms. (issue #1514, issue #1477)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Explain no-issue PR.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.46%. Comparing base (884ad5a) to head (2bb2fb7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3390   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         289      290    +1     
  Lines       30784    30785    +1     
  Branches    11220    11220           
=======================================
+ Hits        28773    28774    +1     
  Misses       1355     1355           
  Partials      656      656
Files with missing lines Coverage Δ
packages/gittensory-engine/src/plan-completion.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

loopover-orb[bot]
loopover-orb Bot approved these changes Jul 5, 2026
View reviewed changes

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 0507a11 into JSONbored:main Jul 5, 2026
9 checks passed
@kiannidev kiannidev mentioned this pull request Jul 5, 2026
Closed
3 tasks
@github-actions github-actions Bot mentioned this pull request Jul 8, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loopover-orb loopover-orb[bot] loopover-orb[bot] approved these changes
@JSONbored JSONbored Awaiting requested review from JSONbored JSONbored is a code owner

Assignees

@kiannidev kiannidev

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kiannidev